[DTOSS-12686] - Change Arc-enabled server naming convention to include hospital name and ODS code - #99
Merged
josielsouzanordcloud merged 1 commit intoApr 22, 2026
Conversation
…ospital name and ODS code
Arc resource names are now built from structured inputs rather than a
freeform SiteCode, making them human-readable in the Azure portal and
ADO pipeline logs.
Changes:
- Remove and parameters from arc-setup.ps1
- Add and parameters; build resource name internally
as gw-<SiteName>-<ODSCode>-<Instance> (all lowercase, max 54 chars)
- Remove SiteCode Run Command parameter from gateway-test-vm — script
falls back to the VM hostname (mbsgw-<env>), no re-onboarding needed
- Update relay.tf and outputs.tf comments to remove SiteCode references
- Update onboarding runbook: new parameters table, Hull/RWA example,
fix resource group name prefix (manbgw → mbsgw), add script link,
add PowerShell execution policy guidance and troubleshooting steps
steventux
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$SiteCodeand$PacsVendorparameters fromarc-setup.ps1; replace with structured$ODSCodeand$Instanceinputsgw-<SiteName>-<ODSCode>-<Instance>(all lowercase, max 54 chars), e.g.gw-hull-university-teaching-hospitals-nhs-trust-rwa-01SiteCodeRun Command parameter fromgateway-test-vm— script falls back to the VM hostname (mbsgw-<env>), no re-onboarding of test VMs neededrelay.tfandoutputs.tfcomments to removeSiteCodereferencesmanbgw→mbsgw), script link, PowerShell execution policy guidanceWhy
gw-rwa-01is not human-readable in the Azure portal or ADO pipeline logs. The new convention (gw-hull-university-teaching-hospitals-nhs-trust-rwa-01) identifies the hospital at a glance. Building the name from structured inputs enforces the convention at the script level rather than relying on the caller to format itcorrectly.
Test plan
arc-setup.ps1withSiteName,ODSCode, andInstancesupplied — verify Arc machine appears in the portal with the expected name and tags (ODSCode,Instance,SiteName,NHSRegion,DeploymentRing,SiteType)arc-setup.ps1withoutSiteName/ODSCode— verify script falls back to hostname with no errorhc-gw-<name>mbsgw-review) is unaffected — no re-onboarding requiredJira link
DTOSS-12686
Review notes
Review checklist